S-Trap vs P-Trap: Code Issues Explained

Open the cabinet under almost any sink and you will see a curved piece of pipe. That curve is a trap, and it is one of the most important parts of your plumbing. If you are comparing s trap vs p trap code rules, the short version is this: P-traps are legal everywhere in the United States, and S-traps have been banned by every major plumbing code for decades. Yet S-traps still show up in millions of older homes, and they are one of the most common findings in a home inspection.

What Is a P-Trap?

A P-trap is the U-shaped (technically J-shaped) section of pipe directly below a sink, tub, or shower drain. Its job is simple and critical: it holds a small amount of water in its bend at all times. That standing water forms a seal between your home and the sewer system, blocking sewer gases — including methane and hydrogen sulfide — from rising up through the drain into your living space.

The name comes from the shape. Viewed from the side, the pipe dips down into a U and then rises again before turning horizontal. That horizontal section, called the trap arm, runs to the wall, where it connects to the drain stack and the vent system. The vent is what makes the whole thing work: it lets air into the drain so the water in the trap is not sucked out when a nearby fixture drains.

P-traps are the only trap configuration approved by modern U.S. plumbing codes. They are required under the International Plumbing Code (IPC), used in most of the eastern and central United States, and the Uniform Plumbing Code (UPC), used in much of the West. Every new sink, lavatory, tub, and shower installed in the United States today must have a P-trap, and the trap must be properly vented. If you want a broader picture of what a plumbing inspection covers, see our plumbing inspection checklist.

What Is an S-Trap?

An S-trap looks almost identical to a P-trap at first glance. The difference is what happens after the U-bend. Instead of turning horizontal and running to the wall, an S-trap curves back down again, forming an S shape, and drops straight down through the floor to the drain below.

S-traps were standard in American homes built before roughly the 1950s, and they remained common in do-it-yourself installations well into the 1970s and 1980s. In many older homes the drain was roughed in through the floor, so the S-trap was the natural way to connect a sink to it.

The problem is physics. When water rushes down an S-trap, it can create a siphon effect. The falling column of water pulls the water seal out of the trap behind it, leaving the trap dry. Once the seal is gone, there is nothing between your home and the sewer. Sewer gas flows freely up through the drain, and you get the telltale rotten-egg smell, gurgling drains, and in some cases, a genuine health hazard. This is called "siphoning" or "losing the trap seal," and it is the reason every modern code bans the configuration.

S-traps are especially prone to siphoning when a large volume of water drains quickly — emptying a full kitchen sink, for example — or when a nearby fixture, such as a toilet or washing machine, discharges into a shared drain line and creates negative pressure.

S-Trap vs P-Trap: Key Differences

The table makes the core issue clear: the two traps look similar, but only one is connected to a vent. Without a vent, any trap can lose its seal when pressure changes in the drain system.

Why S-Traps Fail Code

Both major U.S. model plumbing codes prohibit S-traps in plain language. The International Plumbing Code states that fixtures must be trapped with a trap that has a vented trap arm, and that S-traps are not permitted. The Uniform Plumbing Code contains a similar prohibition. Local jurisdictions adopt one of these codes, sometimes with amendments, but none of them allow new S-trap installations.

An existing S-trap in an old home is usually grandfathered — no code requires you to tear out every old trap the day a code changes. The problem comes when the home is sold, renovated, or inspected: a home inspector will flag an S-trap as a defect, a buyer will ask for it to be corrected, and a remodel permit will require the trap to be brought up to current code.

The code violation matters because it is not just a paperwork issue. A dry trap lets sewer gas into the home — hydrogen sulfide is toxic at higher concentrations, and methane is flammable. A trap that loses its seal regularly is a real health and safety problem, not a technicality.

An air admittance valve can help with venting in some cases, but it does not turn an S-trap into a legal P-trap on its own.

How to Tell Which One You Have

You can identify the trap under your sink in about ten seconds. Open the cabinet, find the drain pipe coming down from the sink, and follow its path.

• P-trap: The pipe dips down into a U, comes back up, and then runs horizontally into the wall behind the sink. If the pipe disappears into the wall, you almost certainly have a P-trap.
• S-trap: The pipe dips down into a U, comes back up slightly, and then curves down again and disappears through the floor of the cabinet. If the pipe goes through the floor, you almost certainly have an S-trap.
• Warning signs: A sewer smell under the sink, gurgling when the sink drains, or a trap that is dry when you look inside all point to a trap losing its seal — a classic S-trap symptom.

Check every sink, not just the kitchen. Bathroom lavatories are the most common place to find S-traps, because they are the fixtures most often installed by do-it-yourselfers in older homes. Laundry and bar sinks are also common locations.

If you are not sure what you are looking at, take a photo and show it to a licensed plumber. They can identify the configuration at a glance. A camera inspection of the drain line can also reveal trap and venting problems that are hidden inside walls and floors.

How to Fix an S-Trap

Fixing an S-trap means converting it to a P-trap with a proper vent. The exact work depends on how the drain is roughed in, but the standard repair follows these steps:

1. Reroute the drain through the wall. The plumber opens the wall behind the sink and connects the trap arm horizontally to the drain stack, where a vent is available. This is the core of the fix — the horizontal trap arm is what makes a P-trap a P-trap.

2. Connect to a vent. The trap arm must tie into a vented drain within the distance allowed by code, which depends on the pipe size. For a standard 1-1/2 inch lavatory drain, the vent connection must generally be within about 3-1/2 to 6 feet, depending on the local code. If no vent is nearby, the plumber runs a new vent pipe up through the wall and out the roof, or ties into an existing vent stack.

3. Replace the trap and fittings. The old S-trap assembly is removed and replaced with a proper P-trap, usually in the same material as the existing drain — ABS plastic in many modern homes. Our guide to whether to replace ABS drain pipes explains when the surrounding drain piping itself needs attention.

4. Test the drain. After the work is done, the plumber runs water through the sink and checks that the trap holds its seal, the drain flows freely, and there is no gurgling or odor.

When a vent is already in the wall, the job is a half-day of work. When a new vent must be run through the roof, it takes longer. Either way, this is a job for a licensed plumber — the venting distances, trap arm slope, and fitting choices are all governed by code.

What Inspectors Look For

Home inspectors and plumbing inspectors check traps as part of every inspection. Here is what they look for:

• Trap type: Is it a P-trap? Any S-trap is noted as a defect.
• Trap arm length and slope: The horizontal arm must slope slightly toward the drain — about 1/4 inch per foot — and must not be too long for the pipe size, or the vent will not protect the seal.
• Venting: Is the trap connected to a vented drain? An unvented P-trap can siphon just like an S-trap.
• Double traps: Two traps on one fixture are a violation.
• Improper fittings: Flexible accordion-style drain connectors, which are sold in hardware stores as a quick fix, are not code approved and inspectors flag them.
• Leaks and corrosion: Water stains, mineral buildup, or corrosion around the trap suggest a slow leak.
• Proper materials: The trap and drain must be made of approved materials joined correctly — for ABS systems, that means solvent-welded joints, not glue meant for PVC.

If you are preparing a home for sale, check the traps yourself before the inspector arrives. Replacing an S-trap proactively is a small job compared with the negotiation it can trigger later.

S-Traps When Buying a Home

Finding an S-trap during a home purchase is common and should not scare you away from a house you like — but it should be on your repair list. S-traps are a known, fixable issue, and they are usually grouped with other plumbing corrections in the inspection report.

As a buyer, ask your inspector to note every S-trap in the home. Then get a plumber to quote the conversion. In most cases, converting one or two S-traps is a modest repair, but if every fixture has one and no venting exists in the walls, the job grows. Knowing the scope before closing lets you negotiate a credit or have the seller complete the work.

Also pay attention to the smell test. If you notice a sewer odor during a showing, run water in every sink, tub, and shower, then come back in an hour. If the odor returns, a trap somewhere has lost its seal. It is a simple, free check that catches a real problem.

The broader lesson is that traps are a small part of a larger system. When you find one code issue in an older home, there are often others nearby. A full plumbing inspection gives you the complete picture — see our home inspection guides for everything a thorough inspector examines.

S-traps are a relic of an earlier era of plumbing. A P-trap with a proper vent is the standard, and bringing an old home up to that standard is one of the simplest plumbing improvements you can make.